Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(porting addons to v2): change the recommended package manager to pnpm #1768

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented Jan 24, 2024

This PR is a proposal to change the recommended package manager to pnpm in the Porting Addons to V2 guide.

My understanding is that pnpm is better than yarn to work with Embroider in general, so it may be preferable to recommend pnpm in this document rather than making it more generic about the package manager part.

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great!

@NullVoxPopuli NullVoxPopuli merged commit 69a0e58 into embroider-build:main Jan 24, 2024
95 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
@BlueCutOfficial BlueCutOfficial deleted the docs-porting-addons-to-v2-pnpm branch January 25, 2024 09:10
@sandstrom
Copy link
Contributor

I'm a bit late to the party here, but I would recommend this approach:

I think Ember should pick the package manager that most people are familiar with as its default. Currently, that is NPM. Yes, there are better alternatives (which one is better depend on the project/team, for some the "best manager" is Yarn, for others it is pnpm).

But NPM, with all its flaws, is still the de-facto standard NPM package manager. To keep friction down, I think that should be the Embroider default.

This doesn't preclude us from making it easy to use other package managers, or even offer it as an command line option --package-manager=pnpm.

Also, for everyone discussing this. Keep in mind that this choice shouldn't be optimized on what you (all tech savvy people with tons of JS/front-end experience) knows is "the best choice". Instead, it should be optimized on what makes Ember easy to get started with for the average developer. For all of you, it'll be a breeze to pick another package manager.

-- emberjs/rfcs#820 (comment)

@mansona
Copy link
Member

mansona commented Feb 1, 2024

thanks @sandstrom for the link. That concern isn't entirely relevant for this PR because this is just for the internal documentation that is being used to guide people through the process of upgrading to a v2 addon. When we open this process to a RFC (which will happen once we are ready to make it the default) then we can start sweating the details of our choices 👍

@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants